From 753339c28ad2784af2bff9760533b0ecc0b4fea5 Mon Sep 17 00:00:00 2001
From: Brian Bjarke Jensen <bbj@skov.dk>
Date: Thu, 13 Nov 2025 19:31:36 +0100
Subject: [PATCH 1/2] added check to get user token before loading data

---
 src/baby_monitor/main.py                 |  6 ++
 src/baby_monitor/static/add-child.html   |  6 +-
 src/baby_monitor/static/admin.html       | 34 +++++------
 src/baby_monitor/static/auth-utils.js    | 21 +++++++
 src/baby_monitor/static/diapers.html     |  6 +-
 src/baby_monitor/static/feedings.html    |  6 +-
 src/baby_monitor/static/index.html       | 74 ++++++++++--------------
 src/baby_monitor/static/log-diaper.html  |  6 +-
 src/baby_monitor/static/log-feeding.html |  6 +-
 src/baby_monitor/static/log-sleep.html   |  6 +-
 src/baby_monitor/static/login.html       | 19 +++++-
 src/baby_monitor/static/settings.html    | 14 ++---
 src/baby_monitor/static/sleep.html       |  8 +--
 13 files changed, 112 insertions(+), 100 deletions(-)
 create mode 100644 src/baby_monitor/static/auth-utils.js

diff --git a/src/baby_monitor/main.py b/src/baby_monitor/main.py
index 6fc69c2..fc646a1 100644
--- a/src/baby_monitor/main.py
+++ b/src/baby_monitor/main.py
@@ -143,6 +143,12 @@ def serve_menu_js() -> FileResponse:
     return FileResponse(static_path / "menu.js")
 
 
+@app.get("/auth-utils.js", include_in_schema=False)
+def serve_auth_utils_js() -> FileResponse:
+    """Serve the shared auth utilities JavaScript."""
+    return FileResponse(static_path / "auth-utils.js")
+
+
 @app.get("/api/")
 def read_root(token: Annotated[str, Depends(verify_token)]) -> dict:
     """API root endpoint (requires authentication)."""
diff --git a/src/baby_monitor/static/add-child.html b/src/baby_monitor/static/add-child.html
index 97a97f3..19435b2 100644
--- a/src/baby_monitor/static/add-child.html
+++ b/src/baby_monitor/static/add-child.html
@@ -211,12 +211,10 @@
       </div>
     </div>
 
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Get child ID from URL if editing
       const urlParams = new URLSearchParams(window.location.search);
diff --git a/src/baby_monitor/static/admin.html b/src/baby_monitor/static/admin.html
index acf2843..9434a33 100644
--- a/src/baby_monitor/static/admin.html
+++ b/src/baby_monitor/static/admin.html
@@ -424,35 +424,33 @@
       </div>
     </div>
 
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated and is admin
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       let allUsers = [];
       let userToDelete = null;
 
-      // Verify user is admin and load data
+      // Load data
       fetch("/api/me", {
         headers: {
           Authorization: `Bearer ${token}`,
         },
       })
-        .then((response) => response.json())
-        .then((user) => {
-          if (!user.is_admin) {
-            alert("Access denied. Admin privileges required.");
-            window.location.href = "/";
-          }
-          // Load users after verifying admin status
-          loadUsers();
-        })
-        .catch((error) => {
-          console.error("Error verifying admin status:", error);
-          window.location.href = "/login.html";
-        });
+      .then((response) => response.json())
+      .then((user) => {
+        if (!user.is_admin) {
+          alert("Access denied. Admin privileges required.");
+          window.location.href = "/";
+        }
+        // Load users after verifying admin status
+        loadUsers();
+      })
+      .catch((error) => {
+        console.error("Error verifying admin status:", error);
+        window.location.href = "/login.html";
+      });
 
       async function loadUsers() {
         const container = document.getElementById("userListContainer");
diff --git a/src/baby_monitor/static/auth-utils.js b/src/baby_monitor/static/auth-utils.js
new file mode 100644
index 0000000..d44602a
--- /dev/null
+++ b/src/baby_monitor/static/auth-utils.js
@@ -0,0 +1,21 @@
+/**
+ * Redirect to login page with return URL
+ * @param {string} returnUrl - The URL to return to after login (defaults to current page)
+ */
+function redirectToLogin(returnUrl) {
+  const url = returnUrl || window.location.pathname + window.location.search;
+  window.location.href = `/login.html?return=${encodeURIComponent(url)}`;
+}
+
+/**
+ * Check if user has valid token, redirect to login if not
+ * @returns {string|null} - Returns token if valid, redirects to login if not
+ */
+function getToken() {
+  const token = localStorage.getItem("access_token");
+  if (!token) {
+    redirectToLogin();
+    return null;
+  }
+  return token;
+}
diff --git a/src/baby_monitor/static/diapers.html b/src/baby_monitor/static/diapers.html
index b02239c..f28a6f4 100644
--- a/src/baby_monitor/static/diapers.html
+++ b/src/baby_monitor/static/diapers.html
@@ -266,12 +266,10 @@
 
     <script src="https://cdn.jsdelivr.net/npm/chart.js@4.4.0/dist/chart.umd.min.js"></script>
     <script src="/menu.js"></script>
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Initialize burger menu
       initBurgerMenu({ includeHome: true });
diff --git a/src/baby_monitor/static/feedings.html b/src/baby_monitor/static/feedings.html
index 3336189..0951c7a 100644
--- a/src/baby_monitor/static/feedings.html
+++ b/src/baby_monitor/static/feedings.html
@@ -303,12 +303,10 @@
 
     <script src="https://cdn.jsdelivr.net/npm/chart.js@4.4.0/dist/chart.umd.min.js"></script>
     <script src="/menu.js"></script>
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Initialize burger menu
       initBurgerMenu({ includeHome: true });
diff --git a/src/baby_monitor/static/index.html b/src/baby_monitor/static/index.html
index c382d67..b48f554 100644
--- a/src/baby_monitor/static/index.html
+++ b/src/baby_monitor/static/index.html
@@ -236,59 +236,47 @@
     </div>
 
     <script src="/menu.js"></script>
+    <script src="/auth-utils.js"></script>
     <script>
-      const token = localStorage.getItem("access_token");
+      const token = getToken();
       const username = localStorage.getItem("username");
 
-      // Check if user is logged in
-      if (!token) {
-        window.location.href = "/login.html";
-      } else {
-        // Fetch current user info including admin status
-        fetch("/api/me", {
+      // Fetch current user info including admin status
+      fetch("/api/me", {
+        headers: {
+          Authorization: `Bearer ${token}`,
+        },
+      })
+      .then((response) => response.json())
+      .then((user) => {
+        if (!user) return; // Early exit if redirected
+
+        // Initialize burger menu
+        initBurgerMenu({
+          includeHome: true,
+        });
+
+        // Check if user has any children
+        return fetch("/api/children", {
           headers: {
             Authorization: `Bearer ${token}`,
           },
         })
-          .then((response) => {
-            if (response.ok) {
-              return response.json();
-            } else {
-              // Token invalid, redirect to login
-              localStorage.removeItem("access_token");
-              localStorage.removeItem("username");
-              window.location.href = "/login.html";
-              throw new Error("Authentication failed");
+          .then((response) => response.json())
+          .then((children) => {
+            // If no children, show welcome message with option to add
+            if (children.length === 0) {
+              showNoChildrenMessage();
+              return;
             }
-          })
-          .then((user) => {
-            // Initialize burger menu
-            initBurgerMenu({
-              includeHome: true,
-            });
 
-            // Check if user has any children
-            return fetch("/api/children", {
-              headers: {
-                Authorization: `Bearer ${token}`,
-              },
-            })
-              .then((response) => response.json())
-              .then((children) => {
-                // If no children, show welcome message with option to add
-                if (children.length === 0) {
-                  showNoChildrenMessage();
-                  return;
-                }
-
-                // Load feeding status and show content
-                loadFeedingStatus(children);
-              });
-          })
-          .catch((error) => {
-            console.error("Error:", error);
+            // Load feeding status and show content
+            loadFeedingStatus(children);
           });
-      }
+      })
+      .catch((error) => {
+        console.error("Error:", error);
+      });
 
       function showNoChildrenMessage() {
         const content = document.getElementById("content");
diff --git a/src/baby_monitor/static/log-diaper.html b/src/baby_monitor/static/log-diaper.html
index 2b2813a..b5264a7 100644
--- a/src/baby_monitor/static/log-diaper.html
+++ b/src/baby_monitor/static/log-diaper.html
@@ -242,12 +242,10 @@
       </form>
     </div>
 
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Determine return URL based on referrer
       function getReturnUrl() {
diff --git a/src/baby_monitor/static/log-feeding.html b/src/baby_monitor/static/log-feeding.html
index c1a8fb9..5ef3152 100644
--- a/src/baby_monitor/static/log-feeding.html
+++ b/src/baby_monitor/static/log-feeding.html
@@ -199,12 +199,10 @@
       </form>
     </div>
 
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Determine return URL based on referrer
       function getReturnUrl() {
diff --git a/src/baby_monitor/static/log-sleep.html b/src/baby_monitor/static/log-sleep.html
index aebc53e..d0d2656 100644
--- a/src/baby_monitor/static/log-sleep.html
+++ b/src/baby_monitor/static/log-sleep.html
@@ -189,12 +189,10 @@
       </form>
     </div>
 
+    <script src="/auth-utils.js"></script>
     <script>
       // Check if user is authenticated
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Determine return URL based on referrer
       function getReturnUrl() {
diff --git a/src/baby_monitor/static/login.html b/src/baby_monitor/static/login.html
index eea5bc6..26fd923 100644
--- a/src/baby_monitor/static/login.html
+++ b/src/baby_monitor/static/login.html
@@ -82,10 +82,19 @@
     </div>
 
     <script>
+      // Check if redirected due to expired session
+      const params = new URLSearchParams(window.location.search);
+      const returnUrl = params.get("return");
+      
       const form = document.getElementById("loginForm");
       const messageDiv = document.getElementById("message");
       const loginButton = document.getElementById("loginButton");
 
+      // Show session expired message if redirected from another page
+      if (returnUrl) {
+        showMessage("Your session has expired. Please log in again.", "error");
+      }
+
       form.addEventListener("submit", async (e) => {
         e.preventDefault();
 
@@ -113,9 +122,15 @@
             localStorage.setItem("access_token", data.access_token);
             localStorage.setItem("username", data.username);
 
-            // Redirect based on is_admin from login response
+            // Check for return URL parameter
+            const params = new URLSearchParams(window.location.search);
+            const returnUrl = params.get("return");
+            
+            // Redirect based on return URL or is_admin from login response
             setTimeout(() => {
-              if (data.is_admin === true) {
+              if (returnUrl) {
+                window.location.href = returnUrl;
+              } else if (data.is_admin === true) {
                 window.location.href = "/admin.html";
               } else {
                 window.location.href = "/";
diff --git a/src/baby_monitor/static/settings.html b/src/baby_monitor/static/settings.html
index 4d5efd2..0d64e9a 100644
--- a/src/baby_monitor/static/settings.html
+++ b/src/baby_monitor/static/settings.html
@@ -469,11 +469,9 @@
     </div>
 
     <script src="/menu.js"></script>
+    <script src="/auth-utils.js"></script>
     <script>
-      const token = localStorage.getItem("access_token");
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Initialize burger menu
       initBurgerMenu({ includeHome: true });
@@ -495,7 +493,7 @@
             currentUser = await userResponse.json();
             document.getElementById("username").value = currentUser.username;
           } else {
-            window.location.href = "/login.html";
+            redirectToLogin();
             return;
           }
 
@@ -852,8 +850,10 @@
           }
         });
 
-      // Load data on page load
-      loadData();
+      // Load data on page load (only if authenticated)
+      if (token) {
+        loadData();
+      }
     </script>
   </body>
 </html>
diff --git a/src/baby_monitor/static/sleep.html b/src/baby_monitor/static/sleep.html
index 3d33504..bd4303a 100644
--- a/src/baby_monitor/static/sleep.html
+++ b/src/baby_monitor/static/sleep.html
@@ -313,13 +313,9 @@
 
     <script src="https://cdn.jsdelivr.net/npm/chart.js@4.4.0/dist/chart.umd.min.js"></script>
     <script src="/menu.js"></script>
+    <script src="/auth-utils.js"></script>
     <script>
-      const token = localStorage.getItem("access_token");
-
-      // Check if user is logged in
-      if (!token) {
-        window.location.href = "/login.html";
-      }
+      const token = getToken();
 
       // Initialize burger menu
       initBurgerMenu({ includeHome: true });
-- 
2.54.0


From a966d0bc8e6646996803805cf05059f44e5d979e Mon Sep 17 00:00:00 2001
From: Brian Bjarke Jensen <bbj@skov.dk>
Date: Thu, 13 Nov 2025 22:33:24 +0100
Subject: [PATCH 2/2] cleared logs on login, to avoid stale data

---
 src/baby_monitor/static/login.html | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/src/baby_monitor/static/login.html b/src/baby_monitor/static/login.html
index 26fd923..bc89dfe 100644
--- a/src/baby_monitor/static/login.html
+++ b/src/baby_monitor/static/login.html
@@ -95,6 +95,23 @@
         showMessage("Your session has expired. Please log in again.", "error");
       }
 
+      // Clear user-specific cache data on login
+      function clearUserCache() {
+        const keysToRemove = [
+          'lastDiaperChildFilter',
+          'lastFeedingChildFilter',
+          'lastSleepChildFilter',
+          'lastDiaperTimeRange',
+          'lastFeedingTimeRange'
+        ];
+        
+        keysToRemove.forEach(key => {
+          localStorage.removeItem(key);
+        });
+        
+        console.log('Cleared user cache on login');
+      }
+
       form.addEventListener("submit", async (e) => {
         e.preventDefault();
 
@@ -118,9 +135,13 @@
 
           if (response.ok) {
             showMessage(data.message, "success");
+            
             // Store token in localStorage
             localStorage.setItem("access_token", data.access_token);
             localStorage.setItem("username", data.username);
+            
+            // Clear stale user preferences from previous sessions
+            clearUserCache();
 
             // Check for return URL parameter
             const params = new URLSearchParams(window.location.search);
-- 
2.54.0