mypy fixed types

shared/data_store/connect_minio.py

@@ -23,10 +23,10 @@ def connect_minio() -> Minio:
             env_var
         }"
     # prepare arguments
-    minio_endpoint = os.getenv('MINIO_ENDPOINT')
+    minio_endpoint = os.getenv('MINIO_ENDPOINT', default='')
-    minio_access_key = os.getenv('MINIO_ACCESS_KEY')
+    minio_access_key = os.getenv('MINIO_ACCESS_KEY', default='')
-    minio_secret_key = os.getenv('MINIO_SECRET_KEY')
+    minio_secret_key = os.getenv('MINIO_SECRET_KEY', default='')
-    minio_bucket_name = os.getenv('MINIO_BUCKET_NAME')
+    minio_bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
     # connect client
     client = Minio(
         endpoint=minio_endpoint,

shared/data_store/delete.py

@@ -1,4 +1,5 @@
 """Definition of delete function."""
+
 from __future__ import annotations
 
 import logging
@@ -14,8 +15,8 @@ def delete(
     """Delete object from MinIO."""
     assert isinstance(client, Minio)
     assert isinstance(object_name, str)
-    bucket_name = os.getenv('MINIO_BUCKET_NAME', default=None)
+    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
-    assert isinstance(bucket_name, str)
+    assert len(bucket_name) > 0
     # remove object
     try:
         client.remove_object(

shared/data_store/get.py

@@ -15,12 +15,11 @@ def get(
     """Get buffer from bucket in MinIO."""
     assert isinstance(client, Minio)
     assert isinstance(object_name, str)
-    assert 'MINIO_BUCKET_NAME' in os.environ
+    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
-    bucket_name = os.getenv('MINIO_BUCKET_NAME')
     # get buffer
     try:
         response = client.get_object(
-            bucket_name=bucket_name,  # type: ignore
+            bucket_name=bucket_name,
             object_name=object_name,
         )
         assert response.status == 200

shared/data_store/get_image.py

@@ -18,13 +18,13 @@ def get_image(
     assert len(object_name) > 0
     # prepare arguments
     assert 'MINIO_BUCKET_NAME' in os.environ
-    bucket_name = os.getenv('MINIO_BUCKET_NAME')
+    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
     subfolder = 'images'
     # get object from bucket
     object_name = f'{subfolder}/{object_name}'
     try:
         response = client.get_object(
-            bucket_name=bucket_name,  # type: ignore
+            bucket_name=bucket_name,
             object_name=object_name,
         )
         buffer = BytesIO(response.data)

shared/data_store/put.py

@@ -1,4 +1,5 @@
 """Definition of put function."""
+
 from __future__ import annotations
 
 import logging
@@ -16,8 +17,8 @@ def put(
     """Put buffer in bucket in MinIO and return MD5 checksum as object name."""
     assert isinstance(client, Minio)
     assert isinstance(buffer, BytesIO)
-    bucket_name = os.getenv('MINIO_BUCKET_NAME', default=None)
+    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
-    assert isinstance(bucket_name, str)
+    assert len(bucket_name) > 0
     # get md5 of image
     checksum = md5(buffer.getbuffer()).hexdigest()
     # prepare for saving

shared/data_store/put_image.py

@@ -17,8 +17,8 @@ def put_image(
     used as object name."""
     assert isinstance(client, Minio)
     assert isinstance(image, Image.Image)
-    bucket_name = os.getenv('MINIO_BUCKET_NAME', default=None)
+    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
-    assert isinstance(bucket_name, str)
+    assert len(bucket_name) > 0
     subfolder = 'images'
     # save image to buffer
     buffer = BytesIO()

shared/data_store/put_model.py

@@ -18,8 +18,8 @@ def put_model(
     used as object name."""
     assert isinstance(client, Minio)
     assert isinstance(model, Module)
-    assert 'MINIO_BUCKET_NAME' in os.environ
+    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
-    bucket_name = os.getenv('MINIO_BUCKET_NAME')
+    assert len(bucket_name) > 0
     subfolder = 'models'
     # save image to buffer
     buffer = BytesIO()