updated for readability

shared/datastore/src/get_image.py

@@ -7,6 +7,8 @@ from io import BytesIO
 from minio import Minio
 from PIL import Image
 
+from shared.utils import check_env
+
 
 def get_image(
     client: Minio,
@@ -17,11 +19,10 @@ def get_image(
     assert isinstance(object_name, str)
     assert len(object_name) > 0
     # prepare arguments
-    assert 'MINIO_BUCKET_NAME' in os.environ
+    check_env({'MINIO_BUCKET_NAME'})
-    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
+    bucket_name = str(os.getenv('MINIO_BUCKET_NAME'))
-    subfolder = 'images'
+    object_name = f'images/{object_name}'
     # get object from bucket
-    object_name = f'{subfolder}/{object_name}'
     try:
         response = client.get_object(
             bucket_name=bucket_name,

shared/datastore/src/get_model.py

@@ -1,12 +1,14 @@
 """Definition of get_model function."""
 
 import logging
+import os
 from collections import OrderedDict
+from io import BytesIO
 
 import torch
 from minio import Minio
 
-from .get import get
+from shared.utils import check_env
 
 
 def get_model(
@@ -16,13 +18,24 @@ def get_model(
     """Get model from model subfolder in bucket in Minio."""
     assert isinstance(client, Minio)
     assert isinstance(object_name, str)
-    subfolder = 'models'
+    assert len(object_name) > 0
-    object_name = f'{subfolder}/{object_name}'
+    # prepare arguments
-    # get buffer
+    check_env({'MINIO_BUCKET_NAME_MODELS'})
-    buffer = get(
+    bucket_name = str(os.getenv('MINIO_BUCKET_NAME_MODELS'))
-        client=client,
+    object_name = f'models/{object_name}'
-        object_name=object_name,
+    # get object from bucket
-    )
+    try:
+        response = client.get_object(
+            bucket_name=bucket_name,
+            object_name=object_name,
+        )
+        buffer = BytesIO(response.data)
+    except Exception as exc:
+        logging.error('failed getting data from MinIO')
+        raise exc
+    finally:
+        response.close()
+        response.release_conn()
     # convert data to model checkpoint
     buffer.seek(0)
     model_content = torch.load(buffer)