From 88a20c4b0b862e0d48379d5da96bed8c7be8ae07 Mon Sep 17 00:00:00 2001 From: brian Date: Fri, 28 Feb 2025 22:54:53 +0000 Subject: [PATCH] corrected type hints --- shared/docstore/src/docstore_mongo.py | 8 ++++---- .../src/implementations/mongo_implementation.py | 8 ++++---- .../repositories/src/visual_communication_repository.py | 6 +++--- shared/repositories/tests/integration/conftest.py | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/shared/docstore/src/docstore_mongo.py b/shared/docstore/src/docstore_mongo.py index 9b83a6e..cd665b8 100644 --- a/shared/docstore/src/docstore_mongo.py +++ b/shared/docstore/src/docstore_mongo.py @@ -40,7 +40,7 @@ class DocstoreMongo(DocstoreInterface): mongo_database = str(os.getenv('MONGO_DB')) mongo_collection = str(os.getenv('MONGO_COLLECTION')) # connect client - client = MongoClient(mongo_endpoint) + client: MongoClient = MongoClient(mongo_endpoint) database = client[mongo_database] collection = database[mongo_collection] # set unique index on 'name' @@ -53,9 +53,9 @@ class DocstoreMongo(DocstoreInterface): def close(self) -> None: """Close connection to Mongo server.""" self._client.close() - self._client = None - self._database = None - self._collection = None + self._client = None # type: ignore + self._database = None # type: ignore + self._collection = None # type: ignore def __enter__(self) -> DocstoreMongo: self.connect() diff --git a/shared/repositories/src/implementations/mongo_implementation.py b/shared/repositories/src/implementations/mongo_implementation.py index 1d43439..853cf9b 100644 --- a/shared/repositories/src/implementations/mongo_implementation.py +++ b/shared/repositories/src/implementations/mongo_implementation.py @@ -39,7 +39,7 @@ class MongoImplementation(DatabaseInterface): mongo_database = str(os.getenv('MONGO_DB')) mongo_collection = str(os.getenv('MONGO_COLLECTION')) # connect client - client = MongoClient(mongo_endpoint) + client: MongoClient = MongoClient(mongo_endpoint) database = client[mongo_database] collection = database[mongo_collection] # set unique index on 'name' @@ -52,9 +52,9 @@ class MongoImplementation(DatabaseInterface): def close(self) -> None: """Close connection to Mongo server.""" self._client.close() - self._client = None - self._database = None - self._collection = None + self._client = None # type: ignore + self._database = None # type: ignore + self._collection = None # type: ignore def connected(self) -> bool: """Check connection to Mongo.""" diff --git a/shared/repositories/src/visual_communication_repository.py b/shared/repositories/src/visual_communication_repository.py index 5322906..376ed8f 100644 --- a/shared/repositories/src/visual_communication_repository.py +++ b/shared/repositories/src/visual_communication_repository.py @@ -34,11 +34,11 @@ class VisualCommunicationRepository(VisualCommunicationInterface, MongoImplement """Put visual communication data.""" assert isinstance(data, VisualCommunicationData) # convert to dict - data = data.model_dump(mode='json') + data_dict: dict = data.model_dump(mode='json') # build query - query = {'name': data['name']} + query = {'name': data.name} # save to mongo - self._save(data, query) + self._save(data_dict, query) def remove_data(self, name: str) -> None: """Remove visual communication data.""" diff --git a/shared/repositories/tests/integration/conftest.py b/shared/repositories/tests/integration/conftest.py index a17e012..9f2775a 100644 --- a/shared/repositories/tests/integration/conftest.py +++ b/shared/repositories/tests/integration/conftest.py @@ -328,7 +328,7 @@ def raw_mongo_client( mongo_endpoint = str(os.getenv('MONGO_ENDPOINT')) mongo_database = str(os.getenv('MONGO_DB')) # connect client - client = MongoClient(mongo_endpoint) + client: MongoClient = MongoClient(mongo_endpoint) _ = client[mongo_database] # expose client yield client