From bdf3e73ba9a6b17cad7d528b99f74fb06009db08 Mon Sep 17 00:00:00 2001
From: brian <schnitzelen@gmail.com>
Date: Fri, 25 Oct 2024 17:19:15 +0000
Subject: [PATCH] updated for more general use

---
 shared/datastore/src/get.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/shared/datastore/src/get.py b/shared/datastore/src/get.py
index b41ef63..dfd9206 100644
--- a/shared/datastore/src/get.py
+++ b/shared/datastore/src/get.py
@@ -1,7 +1,6 @@
 """Definition of get function."""
 
 import logging
-import os
 from io import BytesIO
 from traceback import print_exc
 
@@ -10,19 +9,22 @@ from minio import Minio
 
 def get(
     client: Minio,
+    bucket_name: str,
     object_name: str,
 ) -> BytesIO:
     """Get buffer from bucket in MinIO."""
     assert isinstance(client, Minio)
     assert isinstance(object_name, str)
-    bucket_name = os.getenv('MINIO_BUCKET_NAME', default='')
-    # get buffer
+    assert isinstance(bucket_name, str)
+    assert len(bucket_name) > 0
     try:
+        # make request
         response = client.get_object(
             bucket_name=bucket_name,
             object_name=object_name,
         )
         assert response.status == 200
+        # get buffer
         buffer = BytesIO()
         chunk_size = 2**14
         while chunk := response.read(chunk_size):