From 538b26b62fddd9837a0274f038352051539a8905 Mon Sep 17 00:00:00 2001 From: Brian Bjarke Jensen Date: Wed, 17 Sep 2025 12:04:45 +0200 Subject: [PATCH] mypy fixed --- python_repositories/adapters/minio_adapter.py | 7 ++++++- python_repositories/adapters/redis_adapter.py | 11 ++++++++--- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/python_repositories/adapters/minio_adapter.py b/python_repositories/adapters/minio_adapter.py index ada3196..241cfeb 100644 --- a/python_repositories/adapters/minio_adapter.py +++ b/python_repositories/adapters/minio_adapter.py @@ -3,6 +3,7 @@ from __future__ import annotations import os from io import BytesIO +from typing import TYPE_CHECKING import structlog from python_utils import check_env @@ -11,6 +12,10 @@ from python_repositories.interfaces import ( ConnectionAwareInterface, ) +# Import for mypy type checking only +if TYPE_CHECKING: + from minio import Minio, S3Error + class MinioAdapter( ContextAwareInterface, @@ -27,7 +32,7 @@ class MinioAdapter( def __init__(self) -> None: # Import here to avoid hard dependency if MinioAdapter is not used try: - from minio import Minio, S3Error # type: ignore[import] + from minio import Minio, S3Error except ImportError as e: raise RuntimeError("MinioAdapter dependencies missing") from e # Setup logger diff --git a/python_repositories/adapters/redis_adapter.py b/python_repositories/adapters/redis_adapter.py index 1ed86d4..9f40db9 100644 --- a/python_repositories/adapters/redis_adapter.py +++ b/python_repositories/adapters/redis_adapter.py @@ -1,7 +1,7 @@ """Definition of RedisAdapter class.""" from __future__ import annotations -from typing import cast +from typing import cast, TYPE_CHECKING import os import structlog @@ -12,6 +12,11 @@ from python_repositories.interfaces import ( ConnectionAwareInterface, ) +# Import for mypy type checking only +if TYPE_CHECKING: + import redis + from redis.commands.json.path import Path as RedisPath + class RedisAdapter( ContextAwareInterface, @@ -26,8 +31,8 @@ class RedisAdapter( def __init__(self) -> None: # Import here to avoid hard dependency to optional package try: - import redis # type: ignore[import] - from redis.commands.json.path import Path as RedisPath # type: ignore[import] + import redis + from redis.commands.json.path import Path as RedisPath except ImportError as e: raise RuntimeError("RedisAdapter dependencies missing") from e # Setup logger