Extract shared connection lifecycle into ConnectionAwareAdapter.

Move duplicated context-manager, health-check cache, and connection guards from Redis and Minio adapters into an internal base class.

Co-authored-by: Cursor <[email protected]>

python_repositories/adapters/minio_adapter.py

@@ -2,17 +2,14 @@
 
 from __future__ import annotations
 import os
-import structlog
-import time
 from io import BytesIO
-from typing import Self
+
 from python_utils import check_env
 
-from python_repositories.interfaces import (
-    ConnectionAwareInterface,
-    ContextAwareInterface,
-    ObjectRepositoryInterface,
+from python_repositories.adapters.connection_aware_adapter import (
+    ConnectionAwareAdapter,
 )
+from python_repositories.interfaces import ObjectRepositoryInterface
 
 try:
     import minio
@@ -23,11 +20,7 @@ except ImportError as exc:
     ) from exc
 
 
-class MinioAdapter(
-    ObjectRepositoryInterface,
-    ContextAwareInterface,
-    ConnectionAwareInterface,
-):
+class MinioAdapter(ObjectRepositoryInterface, ConnectionAwareAdapter):
     """Minio adapter exposing basic CRUD functionality."""
 
     endpoint_env_var_name: str = "MINIO_ENDPOINT"
@@ -35,14 +28,10 @@ class MinioAdapter(
     secret_key_env_var_name: str = "MINIO_SECRET_KEY"
     bucket_env_var_name: str = "MINIO_BUCKET"
     chunk_size: int = 5 * 2**20  # 5 MiB
-    health_check_ttl_seconds: float = 1.0
+    connection_name: str = "Minio"
 
     def __init__(self) -> None:
-        # Setup logger
-        self.logger = structlog.get_logger(
-            self.__class__.__name__,
-        )
-        # Check environment variables
+        super().__init__()
         check_env(
             {
                 self.endpoint_env_var_name,
@@ -51,31 +40,11 @@ class MinioAdapter(
                 self.bucket_env_var_name,
             },
         )
-        # Prepare internal variables
         self._client: minio.Minio | None = None
         self._bucket_name: str | None = None
-        self._health_check_at: float | None = None
-        self._health_check_ok: bool = False
 
-    def __enter__(self) -> Self:
-        """Enter the context."""
-        self.connect()
-        return self
-
-    def __exit__(
-        self, exc_type: type | None, exc_val: object | None, exc_tb: object | None
-    ) -> None:
-        """Exit the context."""
-        ctx_info = {"exc_type": exc_type, "exc_val": exc_val, "exc_tb": exc_tb}
-        if any(
-            (
-                exc_type is not None,
-                exc_val is not None,
-                exc_tb is not None,
-            ),
-        ):
-            self.logger.error("Error while exiting context", **ctx_info)
-        self.disconnect()
+    def _is_client_ready(self) -> bool:
+        return self._client is not None and self._bucket_name is not None
 
     def connect(self) -> None:
         """Connect to the Minio server."""
@@ -119,10 +88,6 @@ class MinioAdapter(
         self._bucket_name = None
         self._invalidate_health_cache()
 
-    def _invalidate_health_cache(self) -> None:
-        self._health_check_at = None
-        self._health_check_ok = False
-
     def _probe_connection(self) -> bool:
         assert self._client is not None and self._bucket_name is not None
         try:
@@ -130,24 +95,6 @@ class MinioAdapter(
         except Exception:  # pylint: disable=broad-except
             return False
 
-    def is_connected(self) -> bool:
-        """Check if connected to the Minio server."""
-        if self._client is None or self._bucket_name is None:
-            return False
-        now = time.monotonic()
-        if self._health_check_at is not None:
-            seconds_since_last_health_check = now - self._health_check_at
-            cache_is_fresh = (
-                seconds_since_last_health_check < self.health_check_ttl_seconds
-            )
-            if cache_is_fresh:
-                return self._health_check_ok
-        result = self._probe_connection()
-        self._health_check_at = now
-        self._health_check_ok = result
-        self.logger.debug("Connection status", connected=result)
-        return result
-
     def put(
         self,
         object_name: str,
@@ -163,8 +110,7 @@ class MinioAdapter(
         if not isinstance(content_type, str) or len(content_type) == 0:
             raise ValueError("content_type must be a non-empty string")
         # Check connection
-        if not self.is_connected():
-            raise ConnectionError("Not connected to Minio")
+        self._require_connected()
         assert self._client is not None and self._bucket_name is not None
         # Prepare buffer for reading
         num_bytes = data.getbuffer().nbytes
@@ -189,8 +135,7 @@ class MinioAdapter(
         if not isinstance(object_name, str) or len(object_name) == 0:
             raise ValueError("object_name must be a non-empty string")
         # Check connection
-        if not self.is_connected():
-            raise ConnectionError("Not connected to Minio")
+        self._require_connected()
         assert self._client is not None and self._bucket_name is not None
         # Get data from bucket
         # N.B. bucket name is set when connecting
@@ -225,8 +170,7 @@ class MinioAdapter(
         if not isinstance(object_name, str) or len(object_name) == 0:
             raise ValueError("object_name must be a non-empty string")
         # Check connection
-        if not self.is_connected():
-            raise ConnectionError("Not connected to Minio")
+        self._require_connected()
         assert self._client is not None and self._bucket_name is not None
         # Delete object from bucket
         # N.B. bucket name is set when connecting
@@ -245,8 +189,7 @@ class MinioAdapter(
             raise ValueError("prefix must be a string")
         # Check connection
         # N.B. bucket name is set when connecting
-        if not self.is_connected():
-            raise ConnectionError("Not connected to Minio")
+        self._require_connected()
         assert self._client is not None and self._bucket_name is not None
         # List objects in bucket
         objects = self._client.list_objects(