diff --git a/tests/integration/redis_adapter_test.py b/tests/integration/redis_adapter_test.py index 46ac8cc..bb57f24 100644 --- a/tests/integration/redis_adapter_test.py +++ b/tests/integration/redis_adapter_test.py @@ -10,7 +10,7 @@ from redis.commands.json.path import Path as RedisPath from python_repositories.adapters.redis_adapter import RedisAdapter -@pytest.fixture(scope="session") +@pytest.fixture(scope="module") def data() -> Generator[dict[str, str]]: """Provide a sample data dictionary for tests.""" yield {"foo": "bar"} @@ -115,7 +115,6 @@ def test_should_log_error_on_exception_during_exit( raise ValueError("Simulated error") except ValueError: pass # Expected - # Assert error was logged assert "Error while exiting context" in caplog.text @@ -135,8 +134,9 @@ def test_should_get_value( # Arrange key, data = data_in_redis # Act - value = redis_adapter._get(key) + value = redis_adapter._get(key) # type: ignore # Assert + assert value is not None assert value == data @@ -145,7 +145,7 @@ def test_should_get_none_for_missing_key( ) -> None: """Test that getting a non-existent key returns None.""" # Act - value = redis_adapter._get("nonexistent_key") + value = redis_adapter._get("nonexistent_key") # type: ignore # Assert assert value is None @@ -167,7 +167,7 @@ def test_should_raise_connection_error_on_get_when_not_connected( ) -> None: """Test that the RedisAdapter raises ConnectionError when getting while not connected.""" # Arrange - adapter = RedisAdapter() + adapter = RedisAdapter() # not connected # Act & Assert with pytest.raises(ConnectionError): adapter._get("some_key") @@ -180,10 +180,14 @@ def test_should_set_value( """Test that the RedisAdapter can set a value.""" # Arrange key = "test_key" + received_data = redis_adapter._get(key) # type: ignore + assert received_data is None # Ensure key does not exist # Act redis_adapter._set(key, data) # Assert - assert redis_adapter._get(key) == data + received_data = redis_adapter._get(key) # type: ignore + assert received_data is not None + assert received_data == data def test_should_update_value( @@ -194,6 +198,9 @@ def test_should_update_value( # Arrange key, _ = data_in_redis new_data = {"new_key": "new_value"} + received_data = redis_adapter._get(key) # type: ignore + assert received_data is not None + assert received_data != new_data # Act redis_adapter._set(key, new_data) # Assert @@ -246,6 +253,8 @@ def test_should_delete_key( """Test that deleting a key removes it from Redis.""" # Arrange key, _ = data_in_redis + received_data = redis_adapter._get(key) # type: ignore + assert received_data is not None # Ensure key exists # Act redis_adapter._delete(key) # Assert