Enforce 90% combined coverage floor in CI #29
@@ -28,9 +28,11 @@ jobs:
|
||||
|
||||
- name: Run unit tests
|
||||
run: |
|
||||
# --cov-fail-under=0: partial coverage only; floor is checked in coverage-report.
|
||||
uv run pytest tests/unit/ -m "not integration" \
|
||||
--cov=python_repositories \
|
||||
--cov-report=
|
||||
--cov-report= \
|
||||
--cov-fail-under=0
|
||||
|
||||
- name: Upload unit coverage
|
||||
uses: https://github.com/christopherHX/gitea-upload-artifact@v4
|
||||
@@ -64,9 +66,11 @@ jobs:
|
||||
|
||||
- name: Run integration tests
|
||||
run: |
|
||||
# --cov-fail-under=0: partial coverage only; floor is checked in coverage-report.
|
||||
uv run pytest -m integration \
|
||||
--cov=python_repositories \
|
||||
--cov-report=
|
||||
--cov-report= \
|
||||
--cov-fail-under=0
|
||||
|
||||
- name: Upload integration coverage
|
||||
uses: https://github.com/christopherHX/gitea-upload-artifact@v4
|
||||
@@ -77,6 +81,7 @@ jobs:
|
||||
compression-level: 0
|
||||
|
||||
coverage-report:
|
||||
# Merges unit + integration coverage and enforces fail_under from pyproject.toml.
|
||||
needs: [unit-tests, integration-tests]
|
||||
runs-on: ubuntu-latest
|
||||
if: github.event_name == 'pull_request' || github.event_name == 'push'
|
||||
@@ -111,9 +116,24 @@ jobs:
|
||||
|
||||
- name: Combine coverage report
|
||||
run: |
|
||||
# --fail-under=0 so the full report is always written before the floor check.
|
||||
uv run coverage combine coverage-unit/.coverage coverage-integration/.coverage
|
||||
uv run coverage report -m --include='python_repositories/*' > coverage.txt
|
||||
cat coverage.txt
|
||||
uv run coverage report -m --include='python_repositories/*' --fail-under=0 > coverage.txt
|
||||
|
||||
- name: Show coverage report
|
||||
run: cat coverage.txt
|
||||
|
||||
- name: Enforce coverage floor
|
||||
run: |
|
||||
# Reads fail_under from pyproject.toml; only combined coverage is evaluated here.
|
||||
FAIL_UNDER=$(python3 -c "import tomllib; print(tomllib.load(open('pyproject.toml', 'rb'))['tool']['coverage']['report']['fail_under'])")
|
||||
echo "Checking combined coverage against ${FAIL_UNDER}% floor..."
|
||||
if uv run coverage report --fail-under="$FAIL_UNDER" --include='python_repositories/*'; then
|
||||
echo "Coverage floor met."
|
||||
else
|
||||
echo "::error::Combined coverage is below the ${FAIL_UNDER}% floor"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
- name: Post coverage summary to PR
|
||||
if: github.event_name == 'pull_request'
|
||||
|
||||
@@ -148,7 +148,14 @@ uv run pytest -v # full suite (requires Doc
|
||||
|
||||
Integration tests are marked with `@pytest.mark.integration` and require Docker (testcontainers). Run unit tests alone for quick local feedback.
|
||||
|
||||
CI runs unit and integration tests in parallel with coverage, then merges `.coverage` artifacts in a follow-up job (via [christopherhx/gitea-\*-artifact@v4](https://github.com/christopherHX/gitea-upload-artifact) for Gitea 1.26 compatibility).
|
||||
CI runs unit and integration tests in parallel with coverage, then merges `.coverage` artifacts in a follow-up job (via [christopherhx/gitea-\*-artifact@v4](https://github.com/christopherHX/gitea-upload-artifact) for Gitea 1.26 compatibility). Combined coverage must be at least **90%**; the floor is set by [`fail_under` in `pyproject.toml`](pyproject.toml#L45-L48) and enforced after merging unit and integration coverage, not on unit-only runs.
|
||||
|
||||
To check coverage locally (requires Docker for the full suite):
|
||||
|
||||
```bash
|
||||
uv run pytest --cov=python_repositories --cov-report=
|
||||
uv run coverage report
|
||||
```
|
||||
|
||||
`pre-commit` is included in the dev dependency group. `uv sync` installs the CLI, but git does not run hooks until you install them with `pre-commit install` (one time per clone). After that, commits run the checks defined in [`.pre-commit-config.yaml`](.pre-commit-config.yaml) (ruff, mypy, pyupgrade, prettier, and general file hygiene).
|
||||
|
||||
|
||||
@@ -39,6 +39,14 @@ markers = [
|
||||
"integration: tests requiring Docker containers (deselect with '-m \"not integration\"')",
|
||||
]
|
||||
|
||||
[tool.coverage.run]
|
||||
source = ["python_repositories"]
|
||||
|
||||
[tool.coverage.report]
|
||||
fail_under = 90
|
||||
show_missing = true
|
||||
precision = 2
|
||||
|
||||
[tool.uv.sources]
|
||||
python-utils = { index = "gitea" }
|
||||
|
||||
|
||||
Reference in New Issue
Block a user