lille-vemmelund/python-repositories
2
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Releases 17 Activity

Reach 100% combined coverage with targeted unit tests #31

Merged
brian merged 2 commits from cursor/balanced-100-coverage into main 2026-07-07 21:05:53 +02:00
Conversation 2 Commits 2 Files Changed 4
+105 -1
brian commented 2026-07-07 21:02:10 +02:00
Owner
Copy Link
Copy Source

Summary
Add 10 fast unit tests covering gaps integration tests cannot hit: lazy-import dir/getattr helpers and injected-client connect() paths for Redis and MinIO adapters
Raise the combined coverage floor from 90% to 100% in pyproject.toml
Keep CRUD, context-manager, and example-repo coverage in integration tests — no duplicated mock-heavy adapter tests
Test plan

uv run pytest tests/unit/ -v — 72 passed (~0.1s)

uv run pytest -m integration -v — 47 passed (~9s)

Combined coverage report — 100% (402/402 statements)

Summary Add 10 fast unit tests covering gaps integration tests cannot hit: lazy-import __dir__/__getattr__ helpers and injected-client connect() paths for Redis and MinIO adapters Raise the combined coverage floor from 90% to 100% in pyproject.toml Keep CRUD, context-manager, and example-repo coverage in integration tests — no duplicated mock-heavy adapter tests Test plan uv run pytest tests/unit/ -v — 72 passed (~0.1s) uv run pytest -m integration -v — 47 passed (~9s) Combined coverage report — 100% (402/402 statements)
brian added 1 commit 2026-07-07 21:02:11 +02:00
Reach 100% combined coverage with targeted unit tests.
Code Quality Pipeline / code-quality (pull_request) Failing after 29s
Details
Test Python Package / integration-tests (pull_request) Successful in 35s
Details
Test Python Package / unit-tests (pull_request) Successful in 42s
Details
PR Title Check / check-title (pull_request) Successful in 52s
Details
Test Python Package / coverage-report (pull_request) Successful in 12s
Details
beb2b5128e 
Add fast unit tests for lazy-import helpers and injected-client connect paths that integration tests miss, and raise the coverage floor to 100%.

Co-authored-by: Cursor <[email protected]>
ci-bot commented 2026-07-07 21:03:10 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           45      0  100.00%
python_repositories/adapters/minio_adapter.py                     119      0  100.00%
python_repositories/adapters/redis_adapter.py                      96      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/minio_config.py                         31      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               10      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        10      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             402      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 45 0 100.00% python_repositories/adapters/minio_adapter.py 119 0 100.00% python_repositories/adapters/redis_adapter.py 96 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/minio_config.py 31 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 10 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 10 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 402 0 100.00% ```
brian added 1 commit 2026-07-07 21:04:44 +02:00
Fix mypy unreachable-code warning in minio reconnect test.
PR Title Check / check-title (pull_request) Successful in 7s
Details
Test Python Package / coverage-report (pull_request) Successful in 12s
Details
Code Quality Pipeline / code-quality (pull_request) Successful in 48s
Details
Test Python Package / unit-tests (pull_request) Successful in 19s
Details
Test Python Package / integration-tests (pull_request) Successful in 28s
Details
39b104383c 
Drop bucket_name assertions that mypy treated as always false after manually clearing _bucket_name.

Co-authored-by: Cursor <[email protected]>
ci-bot commented 2026-07-07 21:05:30 +02:00
Member
Copy Link
Copy Source

Test Coverage Report:

Name                                                            Stmts   Miss    Cover   Missing
-----------------------------------------------------------------------------------------------
python_repositories/__init__.py                                    12      0  100.00%
python_repositories/adapters/__init__.py                           13      0  100.00%
python_repositories/adapters/connection_aware_adapter.py           45      0  100.00%
python_repositories/adapters/minio_adapter.py                     119      0  100.00%
python_repositories/adapters/redis_adapter.py                      96      0  100.00%
python_repositories/config/__init__.py                              4      0  100.00%
python_repositories/config/dotenv_loader.py                         7      0  100.00%
python_repositories/config/minio_config.py                         31      0  100.00%
python_repositories/config/redis_config.py                         14      0  100.00%
python_repositories/examples/__init__.py                            0      0  100.00%
python_repositories/examples/artifact_object_repository.py          9      0  100.00%
python_repositories/examples/user_json_repository.py               10      0  100.00%
python_repositories/interfaces/__init__.py                          5      0  100.00%
python_repositories/interfaces/connection_aware_interface.py        8      0  100.00%
python_repositories/interfaces/context_aware_interface.py           8      0  100.00%
python_repositories/interfaces/json_repository_interface.py        10      0  100.00%
python_repositories/interfaces/object_repository_interface.py      11      0  100.00%
-----------------------------------------------------------------------------------------------
TOTAL                                                             402      0  100.00%
**Test Coverage Report:** ``` Name Stmts Miss Cover Missing ----------------------------------------------------------------------------------------------- python_repositories/__init__.py 12 0 100.00% python_repositories/adapters/__init__.py 13 0 100.00% python_repositories/adapters/connection_aware_adapter.py 45 0 100.00% python_repositories/adapters/minio_adapter.py 119 0 100.00% python_repositories/adapters/redis_adapter.py 96 0 100.00% python_repositories/config/__init__.py 4 0 100.00% python_repositories/config/dotenv_loader.py 7 0 100.00% python_repositories/config/minio_config.py 31 0 100.00% python_repositories/config/redis_config.py 14 0 100.00% python_repositories/examples/__init__.py 0 0 100.00% python_repositories/examples/artifact_object_repository.py 9 0 100.00% python_repositories/examples/user_json_repository.py 10 0 100.00% python_repositories/interfaces/__init__.py 5 0 100.00% python_repositories/interfaces/connection_aware_interface.py 8 0 100.00% python_repositories/interfaces/context_aware_interface.py 8 0 100.00% python_repositories/interfaces/json_repository_interface.py 10 0 100.00% python_repositories/interfaces/object_repository_interface.py 11 0 100.00% ----------------------------------------------------------------------------------------------- TOTAL 402 0 100.00% ```
brian merged commit b1210bddf2 into main 2026-07-07 21:05:53 +02:00
brian deleted branch cursor/balanced-100-coverage 2026-07-07 21:05:53 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
brian (Brian Bjarke Jensen) ci-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lille-vemmelund/python-repositories#31